Use impl substs in #[rustc_on_unimplemented]
#94689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
compiler-errors
force-pushed
the
on-unimplemented-substs
branch
from
a96d38d
to
f860cec
Compare
compiler-errors
commented
Mar 7, 2022
compiler-errors
force-pushed
the
on-unimplemented-substs
branch
from
f860cec
to
e9ddb8f
Compare
compiler-errors
commented
Mar 7, 2022
| @@ -1,6 +1,7 @@ | |||
| // test for #87707 | |||
| // edition:2018 | |||
| // run-fail | |||
| // exec-env:RUST_BACKTRACE=0 | |||
There was a problem hiding this comment.
Drive-by so I don't keep accidentally changing the output of issue-87707.run.stderr because my environment has RUST_BACKTRACE=full by default.
|
@bors r+ |
|
📌 Commit b726bfb has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 8, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#94689 (Use impl substs in `#[rustc_on_unimplemented]`) - rust-lang#94714 (Enable `close_read_wakes_up` test on Windows) - rust-lang#94723 (Add core::hint::must_use) - rust-lang#94724 (unix: Avoid name conversions in `remove_dir_all_recursive`) - rust-lang#94730 (Reverted atomic_mut_ptr feature removal causing compilation break) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using the trait-ref substs instead of impl substs in
rustc_on_unimplemented, even when computing therustc_on_unimplementedattached to an impl block. Let's not do that.This PR also untangles impl and trait def-ids in the logic in
on_unimplementeda bit.Fixes #94675